Subject: [drinks] few comments on spp-protocol-over-soap-00

From: "Ali, Syed Wasim" <[email-masked]>
Date: Wed, 1 Feb 2012 08:21:35 -0500

Hi,

Here are a few things to consider:

page 12: typo: change "rage" to "range"

general comment: I think repetition of terminology is contributing to the bulk of the document. For example, 'clienttransid:', 'minorVer:'. If the meaning hasn't changed, perhaps a back-reference of a sort should help.

page 13: In past discussions, I think we agreed that the transaction id should be a token. If so, the following definition can be updated to reflect this:

     <simpleType name="TransIdType">
       <restriction base="string"/>
     </simpleType>

page 19: "an specific object" to "a specific object"

Embedded schema in the WSDL not only makes the definition appear too big, it affects readability. I think we should use the import statement within WSDL and separately list the schema.

It is considered good practice to have different targetNamespace values for the WSDL and the schema. I remember reading about some tools getting confused between the two values, something to the effect of endpoint mapping issues.

Thanks,

-Syed